Repository navigation
topology/cmake: skip all topologies when alsatplg < 1.2.5 - #8377
Merged
Merged
Conversation
We want to use it in topology1 too. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Stop producing corrupted .tplg files when using `codec_consumer` (e.g.: sof-imx8mp-btsco-dual-8ch.tplg, sof-imx8ulp-9x9-btsco-16k.tplg, ...) Then we'll be able to finally search/replace "codec_master", see revert Signed-off-by: Marc Herbert <marc.herbert@intel.com>
marc-hb
force-pushed
the
alsatplg-min-125
branch
from
October 23, 2023 22:32
6f99adb to
6ed8425
Compare
marc-hb
marked this pull request as ready for review
October 23, 2023 22:50
marc-hb
requested review from
RanderWang,
aiChaoSONG,
cujomalainey,
dbaluta,
fredoh9,
iuliana-prodan,
keqiaozhang,
plbossart and
ranj063
October 23, 2023 22:53
cujomalainey
approved these changes
Oct 23, 2023
| # Being written in C, `alsatplg` silently ignores some invalid inputs | ||
| # and produces an corrupt .tplg file instead of returning an error code | ||
| # that fails the build. For instance, alsatplg versions < 1.2.5 silently | ||
| # corrupt `codec_consumer` and turn it into `codec_master` instead. |
Contributor
There was a problem hiding this comment.
nit: some grammer tense issues
Collaborator
Author
There was a problem hiding this comment.
Thanks for the prompt review!
Could you be more precise about the grammar issues?
I found "produces A corrupt..." and nothing else (and that's not a tense). Google docs and MS Word don't find anything either.
Collaborator
Author
|
https://sof-ci.01.org/sofpr/PR8377/build14077/devicetest and https://sof-ci.01.org/sofpr/PR8377/build14078/devicetest are 100% green, even suspend/resume. Suspicious! |
kv2019i
approved these changes
Oct 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop producing corrupted .tplg files when using
codec_consumer(e.g.:sof-imx8mp-btsco-dual-8ch.tplg, sof-imx8ulp-9x9-btsco-16k.tplg, ...)
Then we'll be able to finally search/replace "codec_master", see revert #5192